Use diagnostic constraint COCOS consistent with EFIT - #97
Merged
Merged
Conversation
This addresses #96 and should be tested against gafusion/omas#435 EFIT outputs the inferred flux variables (psi, psi_axis, etc) with a different convention than the diagnostic constraints (e.g. flux_loops) so the input COCOS for these need to be different. The constraints are now consistent with the input COCOS of the magnetics IDS.
Closed
These still need to have the same COCOS as the equilibrium psi since they aren't direct diagnostic measurements.
Collaborator
|
@torrinba This looks good. |
AreWeDreaming
approved these changes
Sep 10, 2026
AreWeDreaming
left a comment
AreWeDreaming
left a comment
Collaborator
There was a problem hiding this comment.
This is an important fix that has been verified downstream via IDA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #96 and should be tested against gafusion/omas#435
EFIT outputs the inferred flux variables (psi, psi_axis, etc) with a different convention than the diagnostic constraints (e.g. flux_loops) so the input COCOS for these need to be different. The constraints are now consistent with the input COCOS of the magnetics IDS.
Joey should be assigned to review this as well, but needs to be added to this organization first (which I can't do).