Repository navigation
Let create_batch's duplicate check account for curriculum - #2007
Merged
vikrantwiz02 merged 1 commit intoOct 7, 2026
Conversation
Batch uniqueness was relaxed to (name, discipline, year, curriculum) so a discipline can run two curricula in the same batch year, but this view's own hand-rolled duplicate check still only looked at (name, discipline, year), rejecting the second curriculum's batch before it ever reached the database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batchuniqueness was relaxed to(name, discipline, year, curriculum)so a discipline can run two curricula in the same batch year (e.g. Natural Sciences Physics and Maths tracks) — see the earlier migration0057_batch_unique_with_curriculum.create_batch's own hand-rolled duplicate check never got updated to match: it only filtered on(name, discipline, year, running_batch=True), so adding a second curriculum's batch for the same discipline/year was rejected with a 400 before the request ever reached the database.curriculum=curriculum_objto that filter so it matches the DB constraint.Test plan
python -m ast