Refactor Force and Monarch to Improve Encapsulation and Game Logic - #153
Open
JaskRendix wants to merge 1 commit into
Open
JaskRendix wants to merge 1 commit into
JaskRendix wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
MonarchintoForceto improve encapsulationisUnderprovisioned()toForceto determine whether naval capacity is sufficient for land unitsdownsizeToLimit(double)to handle strength‑based downsizing of forcesgetCustomPrice(...)to compute mercenary pricing based on player‑specific purchase costsdownsizeToPrice(...)to reduce a force until it fits within a player’s available goldscaleLandUnits(int)to support incremental growth of the Intervention Forcecopy()to allow safe simulation of force adjustments without modifying the originalprepareToBoard(UnitType)to more cleanly ensure adequate naval transport capacityMonarchto use high‑levelForcemethods instead of manually iterating over unit listsForcehelpersdownsizeToLimitto avoid overpowered assistanceMonarchnow decides when to act, whileForcehandles how to adjust units and capacity