fix: correct publish_message return value when no recipients - #2094
fix: correct publish_message return value when no recipients#2094lxcxjxhx wants to merge 1 commit into
Conversation
Fixes #2082 Environment.publish_message drops messages to unregistered roles but returns True. This fix returns False when message cannot be delivered to any recipient. Changes: - Changed return value from True to False when no recipients found - Maintains backward compatibility for successful deliveries
|
Hi @better629 @cmodi-meta @Ruyuan37, this PR fixes #2082 by returning False when publish_message has no matching recipients, instead of silently returning True. The Unit Tests CI has passed. Could you please review and approve the Full Tests workflow? Thanks! |
|
Hi @better629 @cmodi-meta @Ruyuan37, This is a gentle follow-up on PR #2094 which fixes issue #2082. The Unit Tests have passed successfully, but the Full Tests workflow is still waiting for approval. Could you please review and approve the Full Tests workflow when you have a moment? This is a small but important fix that improves error handling in the publish_message function by returning False when no recipients match, so callers can detect delivery failures. Thank you for your time! |
|
Closing: no maintainer activity since 2026-07-08. Will reopen if needed. |
Fixes #2082
Problem
Environment.publish_messagedrops messages addressed to unregistered roles and unconditionally returnsTrue, giving the caller no signal that the delivery failed. Whensend_tomatches no registered address, the function logs a warning but still reports success — a producer Role performing a handoff has no machine-readable way to detect the lost message.Solution
Return
Falsewhen no recipients match, so callers can detect delivery failures.Changes
TruetoFalsewhen no recipients are foundTrue)