Repository navigation
test(phpunit): force array cache and Discord off in tests (#47) - #48
Merged
Merged
Conversation
Laravel reads $_SERVER before $_ENV, so a real CACHE_STORE or DISCORD_ENABLE environment variable (e.g. in a container) beat the phpunit.xml values: tests posted to Discord and AnepcFeedHealthTest would flush a real cache store. Force both via <env> and <server>. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Problem
phpunit.xmlsetCACHE_STORE=arraywithoutforce, and did not touchDISCORD_ENABLE. Laravel'senv()reads$_SERVERfirst, so a real environment variable (e.g. inside a container) wins:AnepcFeedHealthTestcallsCache::flush(), which would wipe a real cache store.Change
Force
CACHE_STORE=arrayandDISCORD_ENABLE=falsevia both<env force="true">and<server force="true">(<env force>alone only sets$_ENV/putenv, not$_SERVER).Tests
Ran with
-e CACHE_STORE=redis -e REDIS_HOST=127.0.0.2 -e DISCORD_ENABLE=true:AnepcFeedHealthTest5/5 errors (tries to use Redis);DISCORD_ENABLE=false,cache.default=array.Deploy
Nothing to deploy (test config only).
🤖 Generated with Claude Code