Repository navigation
fix(incidents): stop ICNF/ANEPC flapping and scope the stale guard (#45) - #46
Merged
Merged
Conversation
- ProcessICNFNewFireData only reactivates ICNF-only incidents while the ANEPC feed is stale. While it is fresh it just closes Extinto fires, so it no longer undoes CheckIsActive every run. - CheckIsActive skips cleanup on a stale feed only when dispatched with guardAnepcFeedHealth (ProcessOcorrenciasSite). ProcessANPCAllDataV2 / anepc:sync cleans up from its own list again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Follow-up to the Codex review on #43.
Change
ProcessICNFNewFireData): ICNF-only incidents are reactivated by ICNF only while the ANEPC feed is stale. While ANEPC is fresh the ICNF job only closesExtintofires and never reopens, so it no longer undoesCheckIsActiveon every run.CheckIsActive): newguardAnepcFeedHealthflag (defaultfalse). OnlyProcessOcorrenciasSitepassestrue.ProcessANPCAllDataV2(anepc:sync) cleans up from its own list again, regardless of the ArcGIS feed health.Still as before (unchanged by this PR): while ANEPC is fresh, a brand-new ICNF fire is created active and removed by the next
CheckIsActive(≤2 min) if ANEPC does not list it.Tests
Full suite: same 12 pre-existing errors as
main(missingmongodbextension in the local container);php -lOK on the changed jobs.Deploy
php artisan queue:restart(jobs changed). CheckIsActive jobs already queued keep working (the new property defaults tofalse).No env changes, no migrations.
🤖 Generated with Claude Code