feat(eew): announce predicted intensity before warning sound - #546
Draft
archie0732 wants to merge 2 commits into
Draft
feat(eew): announce predicted intensity before warning sound#546archie0732 wants to merge 2 commits into
archie0732 wants to merge 2 commits into
Conversation
New(zh-Hant): 強震監視器會先朗讀地震預估震度,再播放警示音 New(en-US): the seismic monitor announces predicted intensity before the warning sound
Platform: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
在強震監視器顯示於前景時,以系統 TTS 朗讀最新 EEW 預估震度,朗讀完成後才播放原有警示音;新報會中斷舊播報並改讀最新結果。
相關 issue
怎麼驗
自動測試
tool/check/commits.sh upstream/main..HEAD:2 commits 通過tool/dev/analyze.sh:750 files formatted、flutter analyze無問題tool/check/l10n.shtool/check/pubspec_lock.shtool/check/notification_sounds.shtool/check/build_info.shtool/check/layering.shtool/check/storage.shtool/dev/codegen.sh完整
tool/dev/test.sh在 Windows 上為 1474 passed、5 skipped、64 failed;失敗集中於test/tool/*,原因是 Git Bash 將 Windows 路徑轉成D:GitHub...,以及測試暫存 cache 目錄找不到。本次新增測試已另外單獨執行並全部通過。tool/check.sh的 format、analyze 已通過,但 Windows Git Bash 的 tooling gate 將 Git index 中模式為100755的tool/dev/_lib.sh判定為不可執行;其餘 gate 已依專案腳本逐項執行。手動測試
Android Emulator(x86_64):
tool\\run.ps1 -d emulator-5554 --dart-define=DPIP_DEMO_MONITOR=true --dart-define=DPIP_DEMO_MONITOR_SEVERE=true --dart-define=DPIP_DEMO_MONITOR_SOUND=trueiOS 實機尚未在此 Windows 環境測試。
檢查清單
tool/check/commits.sh upstream/main..HEAD通過mise exec -- flutter analyze與mise exec -- flutter test通過(analyze 通過;完整測試受上述 Windows tool tests 影響)AppLocalizations,沒有寫死