Repository navigation
Normalize voter IDs and preserve punctuation in voting links - #1666
jacksonloper wants to merge 6 commits into
Conversation
✅ Deploy Preview for bettervoting ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Equal-Vote/bettervoting/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The controller now normalizes voter IDs before validation and storage, with coverage for the affected upload behaviors. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads each line, Comment |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Resolve conflicts by taking main's removal of the invite email path (Invites template, useSendInvite).
Invites() no longer exists, and main now rejects precinct values unless voter groups are enabled, so enable them in the roll controller test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Description
Admin-supplied voter IDs were stored verbatim even though voter lookup trims whitespace.
AliceandAlicecould bypass duplicate checks while identifying the same voter at login. IDs were also interpolated directly into URLs, so an ID such asAlice?#was interpreted as a query/fragment rather than a credential.Validation
jest --runInBand --silent). Includes encoded API lookup and authentication with punctuation-containing IDs. Silent mode suppresses existing event-queue logging after test completion.tsc --noEmitpassed.git diff --checkpassed.eslint-plugin-security.