Skip to content

staggered_orders_trading: use order_quantity/order_price in warning #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blueyed wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

staggered_orders_trading: use order_quantity/order_price in warning #3648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tentacles/Trading/Mode/staggered_orders_trading_mode/staggered_orders_trading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ async def create_order(
)
if not created_order:
self.logger.warning(
f"No order created for {order_data} (cost: {quantity * order_data.price}): "
f"No order created for {order_data} (cost: {order_quantity * order_price}): "

@GuillaumeDSM GuillaumeDSM Aug 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order_quantity and order_price are initialized in the above for loop that can yield no iteration, in this case, order_quantity and order_price would be unset. To use them in this log, we need to init them before the loop, to be sure they are always set variables

@blueyed blueyed Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Can you let the workflow/tests run? I'm interested to see if there are falling tests.

@GuillaumeDSM GuillaumeDSM Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are not failing atm, it's just a risk if we include this change.
You should be able to run tests on your own setup using pytest with the proper PYTHON_PATH and giving this as argument tentacles/Trading/Mode/staggered_orders_trading_mode (to run staggered_orders_trading_mode tests only)

f"incompatible with exchange minimum rules. "
f"Limits: {symbol_market[trading_enums.ExchangeConstantsMarketStatusColumns.LIMITS.value]}"
)
Expand Down