Repository navigation
perf(ext4): prevent lmbench ext4_create_delete_files_0k_ops timeout by indexing the orphan chain - #2392
Draft
mistcoversmyeyes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2346.
Fixes #2327. Related: #2286.
A large final-unlink backlog repeatedly validates the entire ext4 legacy orphan chain and walks it again to find a reclaim predecessor. This makes create/delete batches increasingly expensive. The default
lat_fssize sweep exceeded its original 120-second deadline; a stopped-state sample during deletion foundvalidate_chaincalled bylegacy_orphan_contains/unlink_inode.Keep a membership/predecessor index for the validated logical chain. Initial use and any aborted index update still validate the complete chain, while normal add/remove transitions update the index under the existing metadata mutation gate. Removal rereads the target and predecessor and verifies allocation, checksums, inode generation and links. Transaction drop/abort invalidates provisional changes; successful logical publication retains them, and an older batch checkpoint cannot revive an invalidated index. Replay invalidates the index. No on-disk format or journal credit budget changes.
ENOUGH,TIMING_OandLOOP_Oexplicitly unset, the originalext4_create_delete_files_0k_ops.shcompleted all default 0/1/4/10 KiB stages with exit status 0 within the same deadline. No size selection, calibration parameter or deadline was changed; this is a completion check, not a controlled throughput comparison.make kernel, rustfmt andgit diff --checkpassed.another_ext4unit tests passed, including index transitions, abort/drop, successful direct/journal/batch publication, and journal failure boundaries.namespace_transactions(including both persistence models),batched_delalloc, andbatched_fragmented_reclaimregressions passed with their filesystem consistency checks.