Conversation
…ion-attr cascade, damage tracking)
Contributor
Author
|
Hey @nicoburns, I decided to convert #693 to draft and break it down into smaller, more focused, reviewable chunks. I think this will make the changes easier to review and lead to better discussions. |
Member
|
This seems like a good idea. This is much more reviewable than the previous PR! But perhaps we ought to start with a design document? |
Contributor
Author
|
Hey @nicoburns, I put together a basic design that I used as a guide while working through the PR: https://gist.github.com/rit3sh-x/c0aa5f7707009565af31d8f6590fd236 Is it sufficient? I can keep it as is. Otherwise, I can put together a more detailed design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
svg-nativefeature flag toblitz-domandblitz-paint. It is additive and disabled by default.<svg>elements are recognized asSpecialElementData::SvgRootand built into anSvgContextafter layout, using the content-box as the viewport.PresHintslevel, while author CSS continues to take precedence.CONSTRUCT_SVGdamage bit and an SVG registry, allowing mutations to a single SVG fragment without affecting unrelated fragments or triggering full HTML box reconstruction.Geometry/painting for shapes,
<use>, hit-testing, and text are intentionally out of scope for this PR and will be addressed in follow-up PRs.Reviewer Note
This PR is a breakdown of #693, which was a very extensive PR. The goal is to split the work into smaller, focused, and independently reviewable chunks.