Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1789259932-parley-whitespace-modes
branch
2 times, most recently
from
September 13, 2026 01:26
6f871fe to
f91005a
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1789259932-parley-whitespace-modes
branch
from
September 16, 2026 21:14
f91005a to
fbf89b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates Parley's whitespace modes and conditional hanging, pinned to
905e59db90f1b63eba2c93efb0a5487d04dc3c85.CSS
pre-linenow usesPreserveBreaks. Whitespace modes travel through resolved styles, allowing Parley's line breaking, alignment, and intrinsic sizing to use the mode of each span.<br>uses a temporaryPreservespan;display: contentsforwards collapsing and wrapping independently.Includes the API migration from Parley 0.11.1 to current upstream: inline-box baselines, cluster styles, and font data/normalized coordinates.
break-spacesstill falls back toPreserve. Line-edge trimming and preserved-tab positioning remain deferred. Parley's existing Unicode separator subset is retained after comparing the proposed expansion with Chrome and Firefox.Validation
blitz-tests, including whitespace modes, nested spans,<br>,display: contents, and out-of-flow offsets.docs/parley.md, at pinned WPT revision5a5b2b591b39c59d5bca77819db305474dcfd18a.WPT counts in this description are left to CI.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/a9f0131145654530a87ad078d0d3c42b
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/a9f0131145654530a87ad078d0d3c42b?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 550 newly passing, 100 newly failing (net +450).
Full diff (450 changed tests)
Generated by the WPT workflow.