Exapnded MUI Typography to include the full DS Typography - #279
Conversation
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
Stories look good.
Can you fix the typo in the commit message?
| controls: { disable: true }, | ||
| }, | ||
| render: () => ( | ||
| <Stack spacing={4} sx={{ maxWidth: 720 }}> |
There was a problem hiding this comment.
Better to remove macWidth from here, otherwise text wraps to next line and leaves blank white space
There was a problem hiding this comment.
I applied the same as I've done it in the mdx stories: applied "max-width: 66ch;" on the typography and not the container. This keeps lines at readable lengths.
Document each DiamondDS typography variant and colour option. Updated colour to a more robust guide, and added the full list of typography colours to the Color dropdown.
e4c1e7a to
963a224
Compare
|
Is it worth a comment when comparing the different typography sizes/types that some are using Outfit and some Inter? |
|
@VictoriaBeilsten-Edmands Requested
I replaced I also reordered the stories so I've done the other changes requested and made a comment on the width. |
Requested fixes: Remove redundant colour-guide labels, simplify deduping, and update the Storybook render. Updates: Replace `TextSizes` with a `Size ramp` story grouped by rendered pixel size. Reorder stories so `Variant guide` and `Colour guide` appear first, followed by `Alignment`. Prettier fix
00d215e to
776f684
Compare
2 participants
This closes #277.
Document each DiamondDS typography variant and colour option. Updated colour to a more robust guide, and added the full list of typography colours to the Color dropdown.