Skip to content

Enhance RDP features and expose additional WASM options - #1764

Open
Tô Nguyễn Đức Mạnh (tonguyenducmanh) wants to merge 9 commits into
Devolutions:masterfrom
tonguyenducmanh:master
Open

Enhance RDP features and expose additional WASM options#1764
Tô Nguyễn Đức Mạnh (tonguyenducmanh) wants to merge 9 commits into
Devolutions:masterfrom
tonguyenducmanh:master

Conversation

@tonguyenducmanh

@tonguyenducmanh Tô Nguyễn Đức Mạnh (tonguyenducmanh) commented Aug 22, 2026

Copy link
Copy Markdown

No description provided.

@github-actions github-actions Bot added maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny scope/web Affects the web/WASM ecosystem size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Aug 22, 2026
mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) reviewed Aug 23, 2026
View reviewed changes
Comment thread crates/iron-remote-desktop/src/lib.rs Outdated
@github-actions github-actions Bot added breaking-change Includes a breaking change, and requires special scrutiny at the boundaries kind/protocol Affects RDP or related protocol behavior kind/technical-debt Internal cleanup work risk/medium Behavioral change that does not substantially alter a core public API scope/cross-cutting Spans multiple architectural boundaries and removed risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny labels Sep 10, 2026
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Automated review will not run because this contributor is not yet eligible under the automation policy.

Contributors become eligible after one qualifying IronRDP pull request is merged into master. Maintainer review is required.

CBenoit
Benoît Cortier (CBenoit) requested changes Sep 16, 2026
View reviewed changes

@CBenoit Benoît Cortier (CBenoit) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

As per the design principle documented here, I think these should be provided as extensions instead of be part of the common abstraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) mamoreau-devolutions left review comments
@CBenoit Benoît Cortier (CBenoit) CBenoit requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

breaking-change Includes a breaking change, and requires special scrutiny at the boundaries kind/protocol Affects RDP or related protocol behavior kind/technical-debt Internal cleanup work maintainer-required Maintainer review or intervention is required risk/medium Behavioral change that does not substantially alter a core public API scope/cross-cutting Spans multiple architectural boundaries scope/web Affects the web/WASM ecosystem size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonguyenducmanh @CBenoit @mamoreau-devolutions