Grids: extract dataController remoteOperations normalization into utils

[bit-byte0]

What

The grids' data controller now resolves the remoteOperations option through a dedicated helper instead of inline logiс

How

The 'auto', true and groupPaging normalization and the store-type checks moved out of _createDataSourceAdapter into a new utils/adapter.ts module that the controller calls

[Copilot]

Pull request overview

This PR refactors Grid Core’s data controller to normalize the remoteOperations option via a dedicated utility helper, aiming to keep behavior unchanged while improving encapsulation and testability.

Changes:

• Extracted remoteOperations normalization (including 'auto', true, and groupPaging handling) into utils/adapter.ts.
• Simplified DataController._createDataSourceAdapter by delegating normalization to the helper.
• Added Jest coverage for the new normalization and store-type helpers.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/adapter.ts	Introduces store-type checks and remoteOperations normalization helper.
packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/tests/adapter.test.ts	Adds Jest tests covering store detection and normalization behavior.
packages/devextreme/js/__internal/grids/grid_core/data_controller/types.ts	Adds new types for remoteOperations mode/options used by the helper.
packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts	Replaces inline normalization with a call to the extracted helper.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/adapter.ts:27

• The groupPaging normalization currently uses object spread ({ ...enabledRemoteOperations, ...remoteOperations }). This subtly changes behavior vs the previous extend(...) logic: spread will overwrite defaults with undefined values (disabling operations that were previously kept enabled) and it ignores enumerable properties coming from the prototype chain. To keep normalization behavior stable, merge via a for..in loop that skips undefined values (and guards against __proto__/constructor).

  // groupPaging only works when every operation runs remotely.
  if (isObject(remoteOperations) && remoteOperations.groupPaging) {
    return { ...enabledRemoteOperations, ...remoteOperations };
  }

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/tests/adapter.test.ts:80

• The new tests cover the main normalization branches, but they don’t assert the legacy behavior that undefined flags should not override the default enabled operations in the groupPaging merge (previously extend skipped undefined). Adding a regression test for this helps prevent reintroducing the subtle undefined→falsy behavior change.

  it('groupPaging object overrides individual operation flags', () => {
    const result = normalizeRemoteOperations({ groupPaging: true, filtering: false }, remoteStore);

    expect(result).toEqual({
      filtering: false,
      sorting: true,
      paging: true,
      grouping: true,
      summary: true,
      groupPaging: true,
    });
  });

packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/adapter.ts:27

• remoteOperations.groupPaging branch uses object spread to merge defaults, but the previous implementation used extend, which intentionally skips keys whose value is undefined. With the current spread merge, a user-provided object like { groupPaging: true, filtering: undefined } will overwrite the default filtering: true with undefined, which then behaves as false in downstream checks (e.g. !remoteOperations.filtering). Consider merging while ignoring undefined values to preserve the old semantics.

  // groupPaging only works when every operation runs remotely.
  if (isObject(remoteOperations) && remoteOperations.groupPaging) {
    return { ...enabledRemoteOperations, ...remoteOperations };
  }