Repository navigation
FFL-3568: Share precomputed fixtures and lossless numeric policy - #4101
Draft
leoromanovsky wants to merge 7 commits into
Draft
leoromanovsky wants to merge 7 commits into
leoromanovsky wants to merge 7 commits into
Conversation
Run the canonical JSON corpus through the client and persistent cache. Enforce numeric getter types, preserve legacy number reads, and automate signed fixture refreshes.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 5ff5ae5 | Docs | View more details | Give us feedback! |
Open
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run 57 shared precomputed JSON fixtures through public getters, persistent cache restoration, and actual event records. Accept lossless numeric conversions regardless of the numeric wire label. Reject fractional Int reads, range overflow, and inexact Double conversion with
TYPE_MISMATCH.Motivation
Mobile SDKs need one response policy and automatic coverage when upstream cases are added. Ref: FFL-3568.
Additional Notes
Use pinned generated snapshots, integrity checks, a weekly draft update workflow, and module README instructions. No Git submodule or numeric capability is added. Upstream CI enforces generated plain/obfuscated fixture parity. Merge the canonical contract first.
Coverage includes valid and malformed obfuscation, native numeric boundaries, event identity, and exposure suppression. Unsupported variation types are isolated without rejecting valid neighboring flags. Device and live backend validation remain open.
This overlaps the converter changes in #4099, which still enforces the previous strict-type contract. Reconcile that overlap before merging either change.
Bundle size: The shared JSON corpus and runner live under
reliability/single-fit/flags/src/test, outside the published Flags module. Inspection of the built release AAR, including its nested JARs, found neither the fixtures nor the runner. The additional test cases therefore add no fixture payload to customer app bundles. Runtime numeric fixes also change SDK code; the total binary-size difference was not measured.Review checklist (to be filled by reviewers)