fix: #436 improve SQL keyword suggestions - #485
Open
liuxy0551 wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
Cythia828
reviewed
Aug 12, 2026
Comment on lines
+699
to
+703
| const candidates = this.collectSuggestionCandidates( | ||
| sqlParserIns, | ||
| parseTree, | ||
| caretTokenIndex | ||
| ); |
Collaborator
There was a problem hiding this comment.
collectSuggestionCandidates 在最坏情况下会跑 3 次 collectCandidates(整棵树 + 语句树 + 仅在首次缓存的语句起始 token 集)。常见未切片场景是 2 次。对大 SQL 输入这是可感知的额外开销。建议补充一个针对大输入的 benchmark,确认回归在可接受范围。
| const children = parseTree.children; | ||
| if (!children?.length) return parseTree; | ||
|
|
||
| for (let index = children.length - 1; index >= 0; index--) { |
Collaborator
There was a problem hiding this comment.
你这里是只向下看一层,它假设 program 的直接子节点就是语句。一旦文法把语句包了一层中间规则(如 program → batch → statement,或 list 规则),收窄会静默回退到整棵树,修复悄悄失效且无报错,确认下这个链路在这种情况下是否有问题?是否需要加一条断言/测试守护该假设?
Collaborator
Author
换行不会触发补全提示,空格会触发。测试了下,修改后按空格依旧是可以出发补全提示的。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本次改动
Fixes #436 优化光标位置的 SQL 关键字补全:
SELECT等下一语句起始关键字keywordFilter回调,支持调用方自定义过滤API 使用方式
keywordFilter针对最终生成的关键字执行:true:保留关键字false:移除关键字效果展示
https://liuxy0551.github.io/monaco-sql-languages/
当前语句关键字补全
补全列表只包含当前查询合法的续写关键字,不再出现
SELECT等下一语句起始关键字。输入部分关键字后的补全
输入
s后,只展示SORT、SORT BY等符合当前位置的候选项。测试