-
Notifications
You must be signed in to change notification settings - Fork 2
feat!(action): simplify v2 flow to CLI incremental/full contract #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f61339f
d59229f
4bc6cf3
220cc37
de457c0
e13086e
060e7e3
6397805
a7259e0
96de6a7
812ed52
bde08fa
fa74487
463ab43
07de887
b6d04c3
3024fdb
ef9fdea
15ea6a8
ef706cc
821ff56
281e85d
0c7612c
b8e508d
664ec59
3bfc007
1013b83
0efc12e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,11 +47,6 @@ on: | |
| options: [push, pull_request] | ||
| required: false | ||
| default: push | ||
| sync_pr_branch: | ||
| description: 'Machine-owned branch used when sync_strategy is pull_request.' | ||
| type: string | ||
| required: false | ||
| default: codeboarding/sync | ||
|
|
||
| # No workflow-level permissions: the single job below requests only what it | ||
| # needs (least privilege), so the default token starts with none. | ||
|
|
@@ -70,6 +65,7 @@ jobs: | |
| permissions: | ||
| contents: write # push the generated baseline branch | ||
| pull-requests: write # workflow_dispatch may exercise pull_request delivery | ||
| id-token: write # mint per-request OIDC credentials for the relay | ||
| steps: | ||
| # Dogfood: run the action from the checked-out repo (uses: ./) so pushes to | ||
| # main exercise the action code on main, not the last published release. | ||
|
|
@@ -145,15 +141,9 @@ jobs: | |
| - uses: ./ | ||
| with: | ||
| mode: sync | ||
| force_full: ${{ inputs.force_full || false }} | ||
| # Push events retain direct delivery to their branch. A manual | ||
| # pull_request-strategy run targets main even though the workflow code | ||
| # itself is checked out from the feature ref being dogfooded. | ||
| target_branch: ${{ github.event_name == 'workflow_dispatch' && inputs.sync_strategy == 'pull_request' && 'main' || github.ref_name }} | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we still need to support this no? I am a bit puzzled what was this line doing and what is the behavior now?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line made a manually dispatched rolling-PR sync target |
||
| sync_strategy: ${{ inputs.sync_strategy || 'push' }} | ||
|
ivanmilevtues marked this conversation as resolved.
|
||
| sync_pr_branch: ${{ inputs.sync_pr_branch || 'codeboarding/sync' }} | ||
| force_full: ${{ inputs.force_full || false }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this workflow is manually dispatched from a non-main ref with Useful? React with 👍 / 👎. |
||
| # App token authenticates the baseline push so the commit is attributed | ||
| # to the CodeBoarding App (logo avatar). Falls back to the workflow token, | ||
| # which can push because this job grants contents: write. | ||
| push_token: ${{ steps.codeboarding-app-token-client.outputs.token || steps.codeboarding-app-token-app.outputs.token || github.token }} | ||
| llm_api_key: ${{ secrets.OPENROUTER_API_KEY }} | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are we dropping the operouter key here?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That line made this repository’s dogfood sync use its own OpenRouter key directly. Removing it switched dogfood to the hosted OIDC tier because the job grants |
||
| github_token: ${{ steps.codeboarding-app-token-client.outputs.token || steps.codeboarding-app-token-app.outputs.token || github.token }} | ||
Uh oh!
There was an error while loading. Please reload this page.