Repository navigation
[Fusion] Add condition alternatives to operation plan nodes - #10843
Open
michaelstaib wants to merge 1 commit into
Open
michaelstaib wants to merge 1 commit into
michaelstaib wants to merge 1 commit into
Conversation
Contributor
Patch coverage100.0% of changed lines covered (123/123)
Project coverage: 59.5% (322088/541353 lines) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step in a Fusion operation plan can now carry "condition alternatives" next to its conditions. Until now a step could only say "skip me when any one of these
@skip/@includeconditions fails". With alternatives it can also say "run me only when at least one of these groups of conditions passes". The plan JSON and YAML formats write the newconditionAlternativesproperty, and the plan JSON format version moves from 1.2.0 to 1.3.0. The planner does not produce alternatives yet, so no existing plan changes; the follow-up PR in this stack does that.Example
A step that fetches two fields, each behind its own
@skipvariable:The step that fetches
detailsandinventorycan now be described like this in the plan:{ "id": 2, "type": "Operation", "conditionAlternatives": [ [{ "variable": "$skipDetails", "passingValue": false }], [{ "variable": "$skipInventory", "passingValue": false }] ] }The step runs when
$skipDetailsisfalseor$skipInventoryisfalse. When both aretrue, nothing is left to fetch and the step is skipped.