Skip to content

Fix variant colors - #11630

Merged
tool4ever merged 1 commit into
Card-Forge:masterfrom
tool4ever:fix1608
Aug 16, 2026
Merged

Fix variant colors#11630
tool4ever merged 1 commit into
Card-Forge:masterfrom
tool4ever:fix1608

Conversation

@tool4ever

Copy link
Copy Markdown
Contributor

Closes #11629

@tool4ever
tool4ever requested a review from Jetz72 August 16, 2026 16:40
@tool4ever
tool4ever merged commit a5abc2b into Card-Forge:master Aug 16, 2026
3 checks passed
@Jetz72

Jetz72 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Hmmm. I think I wrote that that way to account for if a variant specified a mana cost with a different set of colors than the original card. By default color derives from mana cost, so if neither the original nor the variant specify a color indicator, it'd make sense for the variant's color to derive from its own cost.

I suppose we could make the variant's color derive from its cost only if it specifies an override for the original's cost, and otherwise inherit the original's color.

@tool4ever

Copy link
Copy Markdown
Contributor Author

oh yea good point, I can try and tweak that later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Joshua Rosfield incorrectly treated as colorless

3 participants