Repository navigation
feat: track the slim variant in the daily check - #3
Merged
Merged
Conversation
With `slim` enabled the check now requires the `X.Y.Z-slim` tag to exist with every shipped platform (new reason `missing_variant`, so enabling slim on an already-built version triggers the build), and the base-image comparison works per variant: the default image against library/caddy:X.Y.Z as before, the slim image against the base named in its Dockerfile stage, i.e. the caddy-base image on GHCR, whose build time stands in for its push time. Enabling slim without an `AS slim` stage is a configuration error. The example Dockerfile gains the slim stage and the example config enables it.
The FROM-stage and image-reference parsers were removed from the caddy-base image change. The check now only needs the slim stage's base, which must be FROM ghcr.io/<owner>/<name>:<tag> AS slim; parse_slim_base reads it.
The builder sets XCADDY_SETCAP=1, so the copied binary already has cap_net_bind_service. The default stage stays last so a plain `docker build .` produces it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily check now handles slim: it builds when the -slim tag is missing, and rebuilds slim when caddy-base is updated.
Based on #2. Tag v1.2.0 after this merges.