Repository navigation
fix(HoleFiller): share the remaining block budget between targets - #9365
Merged
MukjepScarlet merged 4 commits intoOct 7, 2026
Merged
Conversation
Contributor
|
Thanks for this — sharing the remaining budget instead of the original one looks right, and the regression test with a case that fails on unmodified sources is exactly what makes it easy to trust. Related: this is finding 7 from the audit in #9327. Two small notes for the reviewer:
No user-facing behaviour or settings change here, so nothing needed on the HoleFiller docs page. 🤖 Automated support reply — a human maintainer will review if this doesn't help. |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iterateHoles()returns its original item budget after partially consuming it. In smart mode, three available blocks can therefore queue two separate two-block holes for different targets.Return the remaining budget so later targets cannot spend items already assigned to a hole, while keeping creative mode exempt from the outer budget check. Adds a client regression with two independent player targets for competing holes, sufficient and insufficient budgets, duplicate holes and the creative-mode exemption.
Related to #9327, finding 7.
Validation: build and client game tests passed. The added regression also fails for its intended reason on unmodified sources.