docs: clarify which deaths settings affect Level 2.29.0 island levels - #134
Merged
Conversation
Level 2.29.0 tracks deaths per island itself. Update the config comments so admins can see that team-join-reset and reset-on-new only affect BentoBox's own death counter and placeholder, while counted and max still gate what Level records. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SxX9oscerhv1nsozPbT5aX
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Level 2.29.0 (BentoBoxWorld/Level#459) moves death tracking for island levels out of BentoBox's per-player, per-world death counter and into Level itself, per island. That changes what the four
deathssettings in this game mode's config actually do:countedmaxteam-join-reset%[gamemode]_deaths%placeholder. No effect on levels.reset-on-new-*This PR updates the
@ConfigCommenttext inSettings.javaand the matching comments inconfig.ymlso admins can see which settings still matter for levels. Comment-only change, no keys or defaults altered, so existing configs are unaffected. Also fixes the "reset and island" typo where present.Same change is being opened across all game modes with a deaths block.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SxX9oscerhv1nsozPbT5aX