Add pipeline stats and benchmark flags - #18
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
RaananW
approved these changes
Sep 17, 2026
RaananW
left a comment
Member
There was a problem hiding this comment.
🤖 This review comment was created by an AI agent.
Thank you for the clear implementation and thorough CLI coverage. The new reports are opt-in, run only after a successful write and disposal, and keep the existing output unchanged by default. I found no blocking correctness, lifecycle, bloat, reuse, or CI security issue. CI covers lint, type-checking, tests, and builds, and is green.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--statsand--benchmarkflags to the pipeline CLI.--statsprints total size before and after for the named input and output files, using one unit selected from the total size before.--benchmarkprints completion time, user/system CPU time, RSS, process-lifetime peak RSS, and heap used. Completion time selects one shared unit for all timing rows: ms, s, min, or h.Measurement scope
Size statistics cover the named files, not external buffers/images referenced by glTF. Timing covers pipeline creation (including library loading), execution, output writing, and disposal. RSS and heap are process-wide completion snapshots; peak RSS is explicitly labeled as the process-lifetime high-water mark. Size totals retain the unit chosen from the input size, and CPU times retain the unit chosen from completion time, even when the other values would independently select different units.
Validation
pnpm test tests/e2e/cli.test.ts— 43 passed.pnpm exec eslint packages/cli/src/cli.ts packages/cli/src/benchmark.ts packages/cli/src/format.ts tests/e2e/cli.test.tspnpm typecheckpnpm buildpnpm --filter @babylonjs/node-assets-cli build