Skip to content

Make CompileComprehensiveGLSL complete on Linux Vulkan #1877

Description

@bkaradzic-microsoft

Summary

ShaderCompilation.CompileComprehensiveGLSL does not complete with the Linux Vulkan/lavapipe configuration being added by #1859. The shader compilation reports an error, but the test continues waiting for setSceneReady, so the full UnitTests process hangs.

Reproduction

Source: #1859 at 3c3cbac799ad23e26c1f63a1cb504f80e2e2c398

cmake -G Ninja -B build/Linux \
  -D JAVASCRIPTCORE_LIBRARY=/usr/lib/x86_64-linux-gnu/libjavascriptcoregtk-4.1.so \
  -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore \
  -D CMAKE_BUILD_TYPE=RelWithDebInfo \
  -D BX_CONFIG_DEBUG=ON \
  -D GRAPHICS_API=Vulkan \
  -D BABYLON_DEBUG_TRACE=ON .
cmake --build build/Linux --target UnitTests
cd build/Linux/Apps/UnitTests
VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/lvp_icd.json \
  xvfb-run --auto-servernum ./UnitTests \
  --gtest_filter=ShaderCompilation.CompileComprehensiveGLSL

Observed output includes:

=== Shader Cross-Compilation Test ===
Unable to compile effect:
...
Error: get@app:///Assets/babylon.max.js:56862:36

The process remains in the render loop waiting for setSceneReady; a 45-second isolated run and a 20-minute full-suite run both time out at this test.

Expected

The comprehensive shader test should either compile successfully on Vulkan or fail the gtest promptly with the underlying shader diagnostic. Once fixed, remove the narrow negative filter from the Vulkan Linux CI lane.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions