fix(types): type element lists as tag name strings - #671
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #389
heightElements,widthElements,tableElementsandnonVisualElementswere typed asHTMLElement[], which caused two problems:domlib,index.d.tsdidn't compile at all (Cannot find name 'HTMLElement')dom, the type was wrong: at runtime these are upper-case tag names like['TABLE', 'TD', 'TH', 'IMG'], so something likejuice.widthElements = ['IMG', 'VIDEO']was a type error and needed a castThey're now
string[], with a short doc comment noting the names are upper-case (that's how Juice compares them).To keep DOM types from sneaking back in, the TypeScript test now runs without the
domlib (lib: ["ES2022"],types: ["node"]) and withskipLibCheck: false. With the old types it failed with exactly the four errors from the issue. It also assigns and reads all four lists as strings.Heads-up for anyone who worked around this with a cast like
as unknown as HTMLElement[]: that cast is now a type error, just remove it.🤖 Generated with Claude Code