feat: add addImportantToPseudoClasses option - #670
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #383
Rules with pseudo-classes like
:hovercan't be inlined, so Juice keeps them in a<style>tag, but then the element's inlined styles win over them and the hover state never shows:The new
addImportantToPseudoClassesoption (off by default, as discussed in the issue) adds!importantto the declarations in those rules:What it covers
juice.ignoredPseudos(:hover,:active,:focus,:visited,:link, plus any you add), also inside@mediaand nested&:hover<style>tag in the output: preserved rules, style tags kept withremoveStyleTags: false,removeInlinedSelectorsmode, and preservedextraCss!importantaren't doubledWhat it leaves alone
data-embedstyle tags::first-letteretc., also in the legacy:first-letterform), since inline styles don't override themIt runs as a single pass over the output's
<style>tags at the end ofjuiceDocument, and costs nothing when the option is off.Also available as
--add-important-to-pseudo-classeson the CLI, typed inindex.d.ts, and documented in the README's options table.🤖 Generated with Claude Code