Repository navigation
Conversation
From igoMain chunk
Define messages for conversation channels and events.
- Added "lsx_crypto" to take care of the necessary stuff - Included a method to prepare a challenge response by encrypting a key and deriving a new seed. - Defined custom error types for better error handling.
…'s lazylock, limit requests to prevent 403s, fix potential lib issue
…pendencies updates
Fix all compile errors Fix winit compile error on linux Put rustls into virtual workspace Fix GUI not launching on Linux Run touchup only when needed, set CWD before game launch to fix crashing
…nding on file existence
merge changes from sjp761 to bumps
…cleaner execute flow
…d gameinfo JSON creation
…ling surrounding touchup
… PATH for umu-run on Linux
imLinguin
reviewed
Oct 7, 2026
|
|
||
| let offer_id = game.base_offer().offer_id().to_owned().clone(); | ||
| let slug = game.base_offer().slug().to_owned().clone(); | ||
| drop(maxima); // To unlock before starting the game, since start_game will also need to lock |
Collaborator
There was a problem hiding this comment.
Instead of using drops like this I think using scopes would be better fit
{}
Alternatively extract the functionality that needs a lock to separate function
imLinguin
reviewed
Oct 7, 2026
Comment on lines
+409
to
+413
| if available_live_build.is_none() { | ||
| bail!("Couldn't find a suitable game build"); | ||
| } | ||
|
|
||
| let build = build.unwrap(); | ||
| info!("Installing game build {}", build.to_string()); | ||
| let build = available_live_build.unwrap(); |
Collaborator
There was a problem hiding this comment.
This could be made into
let Some(build) = builds.live_build() else { bail!("....") } ;
Comment on lines
518
to
522
| if build.is_none() { | ||
| bail!("Couldn't find the game build {}", build_id); | ||
| } | ||
|
|
||
| let build = build.unwrap(); |
Collaborator
There was a problem hiding this comment.
similarly here you could you use let Some() stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rework that has been going on the past few months by me and BellezaEmporium.
Belleza's work
My part
This PR also relies on my crates updates for flate2 and async-compression
This PR succeeds #46