Skip to content

[PWGLF] Add kNoSameBunchPileup cut in hStrangeCorrelation.cxx - #17771

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
kcui1:AddRejectSameBunchPileup
Sep 4, 2026
Merged

[PWGLF] Add kNoSameBunchPileup cut in hStrangeCorrelation.cxx#17771
romainschotter merged 1 commit into
AliceO2Group:masterfrom
kcui1:AddRejectSameBunchPileup

Conversation

@kcui1

@kcui1 kcui1 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 13 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add kNoSameBunchPileup cut in hStrangeCorrelation.cxx [PWGLF] Add kNoSameBunchPileup cut in hStrangeCorrelation.cxx Sep 4, 2026
@romainschotter
romainschotter enabled auto-merge (squash) September 4, 2026 14:25
@alibuild

alibuild commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 26dacba at 2026-09-04 16:54:

## sw/BUILD/O2Physics-latest/log
2026-09-04T16:51:40.089+0200 [48068:140058348248704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-09-04T16:51:40.259+0200 [48068:140058348248704] [executioncontext.cpp:739] [ERROR] Failed to download output blob 0c30b50c60bbf5ad17bd34e814b07482d1a272b84a4f0475dfe175f1cc5ae175: 14: recvmsg:Connection reset by peer
2026-09-04T16:51:40.089+0200 [48202:140718422310528] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-09-04T16:51:40.260+0200 [48202:140718422310528] [executioncontext.cpp:739] [ERROR] Failed to download output blob 6203571c842278026b751b8c077dbdb9b7e7ef7ccf75e9b5efed1552325b35da: 14: recvmsg:Connection reset by peer
2026-09-04T16:51:40.089+0200 [48049:140254311075456] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-09-04T16:51:40.261+0200 [48049:140254311075456] [executioncontext.cpp:739] [ERROR] Failed to download output blob b4ac14f58115caf43a36d42838919d3f70900191c635541308b0272f076074d5: 14: recvmsg:Connection reset by peer
2026-09-04T16:51:40.077+0200 [48047:140696708009600] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.261+0200 [48047:140696708009600] [executioncontext.cpp:739] [ERROR] Failed to download output blob 808afa4d7acc374baa4414ce485e2796d5de289b4eee4b7b43fd89a7ed0012a4: 14: Socket closed
2026-09-04T16:51:40.077+0200 [48026:140416387321472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.262+0200 [48026:140416387321472] [executioncontext.cpp:739] [ERROR] Failed to download output blob 7d8305960a1897dad018897b42eeee230bf0892abb7ddc6a69196fa7448c42f7: 14: Socket closed
2026-09-04T16:51:47.447+0200 [39721:140431591063168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-04T16:51:48.619+0200 [38723:140714901241472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-04T16:51:50.575+0200 [47041:140448354758272] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-04T16:51:40.077+0200 [48132:139929605496448] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48132:139929605496448] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48154:140670285258368] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48154:140670285258368] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48204:140142574829184] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48204:140142574829184] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48311:140211191111296] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48311:140211191111296] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48203:140584790621824] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48203:140584790621824] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48288:140182456254080] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48288:140182456254080] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48266:139893468384896] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48266:139893468384896] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48337:139715528126080] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48337:139715528126080] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.127+0200 [48437:140005829901952] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-04T16:51:40.224+0200 [48437:140005829901952] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-04T16:51:40.077+0200 [48048:140284847595136] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48048:140284847595136] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.077+0200 [48359:140137612942976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [48359:140137612942976] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-04T16:51:40.078+0200 [47999:140263267532416] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-04T16:51:40.224+0200 [47999:140263267532416] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 26dacba at 2026-09-04 17:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 64 warnings.'
Found 4 errors and 64 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/c9e264b8c34941a68e63750ab086304d980e404a/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:98:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:848:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1224:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5355:9: error: uninitialized record type: 'triggerStageFills' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 64 -gt 0 ]]
++ cat /sw/BUILD/c9e264b8c34941a68e63750ab086304d980e404a/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1654:75: warning: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3259:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3437:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3679:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3716:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3871:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3956:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4013:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4072:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4122:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4235:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4265:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4523:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4525:41: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4534:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4535:57: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4536:56: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4569:36: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4578:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4580:51: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4653:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4655:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4669:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4680:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4762:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4766:31: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4884:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4885:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4886:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4909:32: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4962:61: warning: use designated initializer list to initialize 'PairLossFinalRecord' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4963:32: warning: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5079:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5093:11: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5127:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5144:15: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit 90a9a8b into AliceO2Group:master Sep 4, 2026
13 of 15 checks passed
@kcui1
kcui1 deleted the AddRejectSameBunchPileup branch September 7, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants