Skip to content

[Common] Only automatically set generator name if not provided in MultModule.h - #17748

Open
romainschotter wants to merge 2 commits into
AliceO2Group:masterfrom
romainschotter:multcentmodule
Open

[Common] Only automatically set generator name if not provided in MultModule.h#17748
romainschotter wants to merge 2 commits into
AliceO2Group:masterfrom
romainschotter:multcentmodule

Conversation

@romainschotter

@romainschotter romainschotter commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator
  • Add condition to automatically set generator name IF not provided (prevents the generator name configurable to get overwritten)

Tagging @jesgum who spotted the issue.

@ddobrigk for your information

@github-actions github-actions Bot added the common label Sep 3, 2026
@github-actions github-actions Bot changed the title Only automatically set generator name if not provided in MultModule.h [Common] Only automatically set generator name if not provided in MultModule.h Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 30 errors, ⚠️ 9 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review September 3, 2026 10:24
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 724e442 at 2026-09-03 15:23:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 28 errors and 54 warnings.'
Found 28 errors and 54 warnings.
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/b49721582305321e921c8bdc490145f812b91bcb/O2Physics-code-check/errors.txt
Common/Tools/Multiplicity/MultModule.h:317:80: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:357:5: error: 'mRunNumber' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:358:5: error: 'mRunNumberCentrality' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:359:5: error: 'lCalibLoaded' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:360:5: error: 'lCalibObjects' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:361:5: error: 'hVtxZFV0A' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:362:5: error: 'hVtxZFT0A' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:363:5: error: 'hVtxZFT0C' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:364:5: error: 'hVtxZFDDA' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:365:5: error: 'hVtxZFDDC' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:366:5: error: 'hVtxZNTracks' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:367:5: error: 'hVtxZNMFTTracks' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:368:5: error: 'hVtxZNGlobalTracks' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:432:14: error: parameter 'name' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:689:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:690:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:691:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:692:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:693:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:694:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:695:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:696:32: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1099:20: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1103:25: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1253:119: error: the const qualified parameter 'generatorName' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1254:38: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1255:32: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1449:19: error: variable 'v0m' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 54 -gt 0 ]]
++ cat /sw/BUILD/b49721582305321e921c8bdc490145f812b91bcb/O2Physics-code-check/warnings.txt
Common/Tools/Multiplicity/MultModule.h:49:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Common/Tools/Multiplicity/MultModule.h:107:14: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/Multiplicity/MultModule.h:394:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/Multiplicity/MultModule.h:426:17: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/Multiplicity/MultModule.h:429:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/Multiplicity/MultModule.h:433:9: warning: member initializer for 'mCalibrationStored' is redundant [modernize-use-default-member-init]
Common/Tools/Multiplicity/MultModule.h:434:9: warning: member initializer for 'mhMultSelCalib' is redundant [modernize-use-default-member-init]
Common/Tools/Multiplicity/MultModule.h:435:9: warning: member initializer for 'mMCScalePars' is redundant [modernize-use-default-member-init]
Common/Tools/Multiplicity/MultModule.h:436:9: warning: member initializer for 'mMCScale' is redundant [modernize-use-default-member-init]
Common/Tools/Multiplicity/MultModule.h:482:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/Multiplicity/MultModule.h:674:13: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/Multiplicity/MultModule.h:872:32: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants