Skip to content

[Common] Rename new centrality getters using different calibration approach - #17463

Merged
ddobrigk merged 3 commits into
AliceO2Group:masterfrom
jesgum:centrality-table-name-change
Aug 14, 2026
Merged

[Common] Rename new centrality getters using different calibration approach#17463
ddobrigk merged 3 commits into
AliceO2Group:masterfrom
jesgum:centrality-table-name-change

Conversation

@jesgum

@jesgum jesgum commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Rename new getters for centrality different calibration approach [Common] Rename new getters for centrality different calibration approach Aug 14, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 30 errors, ⚠️ 32 warnings, 🔕 0 disabled

@jesgum jesgum changed the title [Common] Rename new getters for centrality different calibration approach [Common] Rename new centrality getters using different calibration approach Aug 14, 2026
@jesgum
jesgum marked this pull request as ready for review August 14, 2026 14:59
@ddobrigk
ddobrigk enabled auto-merge (squash) August 14, 2026 15:07
@alibuild

alibuild commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 54e90ff at 2026-08-15 00:23:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 54e90ff at 2026-08-14 19:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 51 errors and 34 warnings.'
Found 51 errors and 34 warnings.
++ [[ 51 -gt 0 ]]
++ cat /sw/BUILD/f5bc2eeacf4f9c420e3a72c03487c56b8f90a883/O2Physics-code-check/errors.txt
Common/Tasks/centralityQa.cxx:42:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:145:16: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:159:14: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:274:71: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:497:7: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:49:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:107:14: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:312:80: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:352:5: error: 'mRunNumber' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:353:5: error: 'mRunNumberCentrality' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:354:5: error: 'lCalibLoaded' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:355:5: error: 'lCalibObjects' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:356:5: error: 'hVtxZFV0A' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:357:5: error: 'hVtxZFT0A' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:358:5: error: 'hVtxZFT0C' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:359:5: error: 'hVtxZFDDA' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:360:5: error: 'hVtxZFDDC' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:361:5: error: 'hVtxZNTracks' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:362:5: error: 'hVtxZNMFTTracks' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:363:5: error: 'hVtxZNGlobalTracks' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:389:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:421:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:424:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:427:14: error: parameter 'name' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:428:9: error: member initializer for 'mCalibrationStored' is redundant [modernize-use-default-member-init,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:429:9: error: member initializer for 'mhMultSelCalib' is redundant [modernize-use-default-member-init,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:430:9: error: member initializer for 'mMCScalePars' is redundant [modernize-use-default-member-init,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:431:9: error: member initializer for 'mMCScale' is redundant [modernize-use-default-member-init,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:476:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:668:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:683:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:684:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:685:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:686:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:687:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:688:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:689:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:690:32: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1061:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1084:20: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1088:11: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:1088:25: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 54e90ff at 2026-08-14 21:00:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk
ddobrigk merged commit 1b9092d into AliceO2Group:master Aug 14, 2026
13 of 17 checks passed
@jesgum
jesgum deleted the centrality-table-name-change branch August 15, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants