Skip to content

[PWGCF] Updated for efficiency correction - #17462

Open
pravatp98 wants to merge 5 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3
Open

[PWGCF] Updated for efficiency correction#17462
pravatp98 wants to merge 5 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3

Conversation

@pravatp98

Copy link
Copy Markdown
Contributor

Updated for efficiency correction and sub-sampling

Updated for  efficiency correction and sub-sampling
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Updated for efficiency correction [PWGCF] Updated for efficiency correction Aug 14, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d0814e2 at 2026-08-14 19:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/ffbf5b7845c9b8727bf3d50aed3e98830ccf3f29/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 0f85e5a at 2026-08-14 21:15:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0f85e5a at 2026-08-15 00:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/cb48a4d8a16dbc4f423cd20c183286a55a5a5ec8/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants