fix(custom,disk): catch fmt::format_error - #5332
Merged
Merged
Conversation
Contributor
|
kylin-liwn
force-pushed
the
fix/custom-format-crash
branch
2 times, most recently
from
September 17, 2026 12:24
ebf1ec3 to
6378a79
Compare
Both modules call fmt::format() with user-controlled format strings. If a placeholder doesn't match any argument, fmt throws format_error. The custom module's catch was re-throwing instead of handling. Disk had none at all. Either way the exception reaches GTK's signal handler — log fills with [error] traces and the bar can crash. Handle it locally: log a warning, skip the affected path, fall back to plain text for the custom module.
kylin-liwn
force-pushed
the
fix/custom-format-crash
branch
from
September 17, 2026 12:28
6378a79 to
436cddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Both modules call fmt::format() with user-controlled format strings. If a placeholder doesn't match any argument, fmt throws format_error. The custom module's catch was re-throwing instead of handling. Disk had none at all.
Either way the exception reaches GTK's signal handler — log fills with [error] traces and the bar can crash.
Handle it locally: log a warning, skip the affected path, fall back to plain text for the custom module.
Related issues
Closes #5275
Checklist
clang-formatninja -C build)man/)