Repository navigation
Duplicate name fix - #669
Merged
Merged
Conversation
…s. Also fixed GOTOOLCHAIN version number in run.sh so it agrees with go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://trello.com/c/4akB0rL9.
The problem here is that the error message is not descriptive enough to make sense to users. DART 3 prevents users saving two jobs with the same name because it's too confusing to have two bags with the same name that contain completely different files. However, when trying to save a bag with a duplicate name the previous error message was too vague, leading users to think they simply needed to delete a duplicate bag from DART's bagging directory.
This fix makes the error message very explicit, telling the user what to fix and how.
This PR also contains some fixes for running DART 3 tests on Windows and on any platform using Go 1.25.0 or higher.