Repository navigation
feat(protocol): encode transaction logs in canonical protobuf - #3904
Open
partylikeits1983 wants to merge 15 commits into
Open
partylikeits1983 wants to merge 15 commits into
partylikeits1983 wants to merge 15 commits into
Conversation
partylikeits1983
added this pull request to stack #3906
September 17, 2026 16:34
This was referenced Oct 5, 2026
This was referenced Oct 6, 2026
partylikeits1983
marked this pull request as ready for review
October 6, 2026 17:09
partylikeits1983
removed this pull request from stack #3906
October 6, 2026 17:20
partylikeits1983
added this pull request to stack #4003
October 6, 2026 17:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds protobuf transport for the transaction logs introduced by the preceding PRs. Proven transactions now encode their submitted
TransactionLogData, and transaction headers carry the corresponding commitment. Public submissions contain complete transaction logs; private submissions contain only a commitment.Local execution data has a separate purpose: transaction arguments retain the secret salt, and transaction effects retain the complete transaction logs and salt needed for local processing. Those messages can contain private data and are not the public transaction submission format.
Please focus review on:
Part 4 of 4. Depends on #3903. Stack: #3833 → #3902 → #3903 → #3904.
Batch and block transaction log transport, including aggregate size limits, is deferred to the separate draft PR #3905. This stack provides transaction execution, proof and signature binding, and transaction protobuf support; it does not provide block storage or query APIs for transaction logs.
Closes #3831.