perf(clickhouse): drop the task event attributes JSON column

Removes the native JSON attributes column from the task events table;
attributes are stored as serialized text.

Mono-RevId: e4c1daf4eb684f03e7edb16318b41c7ab1e3f0c9

Author: carderne

internal-packages/clickhouse/schema/046_drop_task_events_attributes.sql

@@ -0,0 +1,13 @@
+-- +goose Up
+
+-- Writers stopped populating attributes several releases ago. Apply once the
+-- table's TTL has aged out the stored values, so nothing readable is lost.
+-- Metadata-only. The parts are rewritten by normal merges.
+ALTER TABLE trigger_dev.task_events_v2
+    DROP COLUMN IF EXISTS attributes;
+
+-- +goose Down
+
+ALTER TABLE trigger_dev.task_events_v2
+    ADD COLUMN IF NOT EXISTS attributes JSON CODEC(ZSTD(1))
+        AFTER status;

internal-packages/clickhouse/src/taskEvents.test.ts

@@ -39,17 +39,12 @@ function readAttributesText(ch: ClickHouse) {
   return ch.reader.query({
     name: "read-task-event-attributes",
     query: `SELECT attributes_text,
-      toJSONString(attributes) AS attributes_json,
       toUInt8(inserted_at > toDateTime64('2020-01-01 00:00:00', 3)) AS has_inserted_at
     FROM trigger_dev.task_events_v2
     WHERE environment_id = {environmentId: String}
       AND span_id = {spanId: String}`,
     params: z.object({ environmentId: z.string(), spanId: z.string() }),
-    schema: z.object({
-      attributes_text: z.string(),
-      attributes_json: z.string(),
-      has_inserted_at: z.number(),
-    }),
+    schema: z.object({ attributes_text: z.string(), has_inserted_at: z.number() }),
   });
 }
 
@@ -93,24 +88,24 @@ describe("task events v2", () => {
       expect(rows).toEqual([
         {
           attributes_text: '{"z":1,"a":"hello","nested":{"enabled":true}}',
-          // The JSON column is no longer written; only the text is stored.
-          attributes_json: "{}",
           has_inserted_at: 1,
         },
       ]);
     }
   );
 
-  clickhouseTest("attributes_text is a plain stored column", async ({ clickhouseContainer }) => {
-    const ch = new ClickHouse({ url: clickhouseContainer.getConnectionUrl(), name: "test" });
+  clickhouseTest(
+    "attributes_text is the only attributes column",
+    async ({ clickhouseContainer }) => {
+      const ch = new ClickHouse({ url: clickhouseContainer.getConnectionUrl(), name: "test" });
 
-    const [columnError, columns] = await readColumnKinds(ch)({});
-    expect(columnError).toBeNull();
-    expect(columns).toEqual([
-      { name: "attributes", default_kind: "", default_expression: "" },
-      { name: "attributes_text", default_kind: "", default_expression: "" },
-    ]);
-  });
+      const [columnError, columns] = await readColumnKinds(ch)({});
+      expect(columnError).toBeNull();
+      expect(columns).toEqual([
+        { name: "attributes_text", default_kind: "", default_expression: "" },
+      ]);
+    }
+  );
 
   clickhouseTest("has no attributes text indexes", async ({ clickhouseContainer }) => {
     const ch = new ClickHouse({ url: clickhouseContainer.getConnectionUrl(), name: "test" });

internal-packages/clickhouse/src/taskEvents.ts

@@ -258,11 +258,7 @@ export function insertTaskEventsV2(
     table: "trigger_dev.task_events_v2",
     columns: TASK_EVENT_V2_INSERT_COLUMNS,
     settings: {
-      enable_json_type: 1,
-      type_json_skip_duplicated_paths: 1,
-      input_format_json_infer_array_of_dynamic_from_array_of_different_types: 1,
       input_format_json_throw_on_bad_escape_sequence: 0,
-      input_format_json_use_string_type_for_ambiguous_paths_in_named_tuples_inference_from_objects: 1,
       ...settings,
     },
   });