From 08015be81d108bf4ccbbdf2991a8a9fe5c4caf8a Mon Sep 17 00:00:00 2001 From: Kevin Cador Date: Wed, 30 Sep 2026 10:28:56 +0200 Subject: [PATCH] fix(developer): keep guide redirect and contents specs in sync Map /docs/api-use-policy and /docs/user-account-limits to their guides so every listed guide has a legacy redirect, and drop the hardcoded guide counts from the contents and redirect specs. The existing per-guide assertions already cover them, and the counts broke master whenever a guide was added. --- projects/developer/src/lib/guides/prepareGuideMarkdown.spec.ts | 1 - projects/developer/src/lib/redirects/guideRedirects.json | 2 ++ .../developer/src/lib/redirects/legacyDocsDestination.spec.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/projects/developer/src/lib/guides/prepareGuideMarkdown.spec.ts b/projects/developer/src/lib/guides/prepareGuideMarkdown.spec.ts index 2e2159d5..17985b3d 100644 --- a/projects/developer/src/lib/guides/prepareGuideMarkdown.spec.ts +++ b/projects/developer/src/lib/guides/prepareGuideMarkdown.spec.ts @@ -46,7 +46,6 @@ describe('guide snapshots', () => { expect(links.sort()).toEqual( [...slugs].filter((slug) => slug !== 'contents').sort(), ); - expect(links).toHaveLength(29); for (const slug of links) { expect(files[`./${slug}.md`]).toMatch(/^# /m); } diff --git a/projects/developer/src/lib/redirects/guideRedirects.json b/projects/developer/src/lib/redirects/guideRedirects.json index 269879c7..c09078ea 100644 --- a/projects/developer/src/lib/redirects/guideRedirects.json +++ b/projects/developer/src/lib/redirects/guideRedirects.json @@ -23,6 +23,8 @@ "/docs/third-party-libraries": "third-party-libraries", "/docs/limted-access": "limted-access", "/docs/search": "search", + "/docs/api-use-policy": "api-use-policy", + "/docs/user-account-limits": "user-account-limits", "/docs/caching-and-fresh-metadata": "caching-and-fresh-data", "/docs/limited-access": "limted-access" } diff --git a/projects/developer/src/lib/redirects/legacyDocsDestination.spec.ts b/projects/developer/src/lib/redirects/legacyDocsDestination.spec.ts index 0e667de7..ef235773 100644 --- a/projects/developer/src/lib/redirects/legacyDocsDestination.spec.ts +++ b/projects/developer/src/lib/redirects/legacyDocsDestination.spec.ts @@ -10,7 +10,7 @@ describe('legacyDocsDestination', () => { it('maps the public docs pages to their guides', () => { const guides = GUIDES.filter(({ slug }) => !slug.startsWith('about-')); - expect(guides).toHaveLength(24); + expect(guides).not.toHaveLength(0); for (const { slug } of guides) { expect(legacyDocsDestination(`/docs/${slug}`)).toBe(