fix(tools): cover late attachments and simplify file outputs

Author: icecrasher321

.agents/skills/add-tools/SKILL.md

@@ -280,12 +280,21 @@ for raw binary responses, not provider JSON containing base64 or tools that fetc
 Keep provider-specific limits and bounded reads; a file declaration is not permission to enlarge
 arbitrary JSON responses.
 
+Attachment readers that download files inside `transformResponse` need their own bounded reads:
+the first response cap does not cover subsequent fetches. Accept `ToolResponseContext` as the third
+transform argument, forward its `signal`, and share one `AttachmentDownloadBudget` across sequential
+downloads. Prefer raw provider endpoints over base64 metadata. Return the same file object in the
+declared `file` / `file[]` output and nested message associations; `FileToolProcessor` stores it once
+and replaces every alias with the same `UserFile` in both workflow and Copilot execution.
+
 Preserve stored `UserFile` fields (`id`, `key`, `url`, `context`, `type`, `name`, `size`) in transforms;
 rebuilding the old `{ name, mimeType, data, size }` shape discards the reference. File outputs do not
 need duplicate inline text/base64 aliases; the file system handles content materialization. When
-an existing tool exposes those aliases or nested inline file data, preserve its legacy version and
+an existing tool explicitly exposes content aliases in its contract, preserve its legacy version and
 use the existing block/tool version pattern for a file-only output. Test a file over 10 MiB through
-executor admission, single persistence, trusted ownership, and the unchanged JSON cap.
+executor admission, single persistence, trusted ownership, and the unchanged JSON cap. Avoid adding
+top-level filename, size, MIME type, URL, or success fields that merely repeat the canonical file or
+tool result; keep additional provider fields only when they convey distinct information.
 
 ### Output Types
 - `'string'`, `'number'`, `'boolean'` - Primitives

.agents/skills/validate-integration/SKILL.md

@@ -351,6 +351,15 @@ If any tool lists, searches, exports, imports, downloads, uploads, paginates, ba
 - [ ] Transforms retain stored `UserFile` identity/access fields, and tests cover a >10 MiB file
       crossing executor admission without another upload. New file outputs contain references only,
       without inline content aliases; preserve legacy versions when removing existing inline fields
+- [ ] Scan every file-producing path, including attachment fetches inside `transformResponse`, URL
+      descriptors, export operations, and old/new block versions; checking download-named tools alone
+      misses late reads that occur after the first response admission
+- [ ] Late attachment reads share a per-call byte budget, bound actual streamed bytes independently
+      of provider size metadata, and forward `ToolResponseContext.signal` through every fetch/read
+- [ ] Both workflow and Copilot tests produce compact `UserFile` outputs; nested message attachment
+      aliases reference the same stored files, with no duplicate upload or raw bytes left behind
+- [ ] New output contracts omit redundant copies of file name, MIME type, size, URL, and success;
+      retained provider metadata has a distinct purpose, and types match the stored-file runtime shape
 - [ ] Large result payloads are summarized, paginated, referenced, or capped rather than raw-dumped
 - [ ] Pagination and download tests cover caps, early stop behavior, or partial-result preservation when relevant
 

apps/docs/components/ui/icon-mapping.ts

@@ -478,6 +478,7 @@ export const blockTypeToIconMap: Record<string, IconComponent> = {
   jotform: JotformIcon,
   jsm: JiraServiceManagementIcon,
   jupyter: JupyterIcon,
+  jupyter_v2: JupyterIcon,
   kalshi: KalshiIcon,
   kalshi_v2: KalshiIcon,
   ketch: KetchIcon,

apps/docs/content/docs/integrations/jupyter.mdx

@@ -6,7 +6,7 @@ description: Manage files, notebooks, kernels, and sessions on a Jupyter server
 import { BlockInfoCard } from "@/components/ui/block-info-card"
 
 <BlockInfoCard 
-  type="jupyter"
+  type="jupyter_v2"
   color="#FFFFFF"
 />
 
@@ -61,7 +61,7 @@ List files, notebooks, and subdirectories at a path on a Jupyter server
 
 ### Jupyter Get Content
 
-Read a file or notebook from a Jupyter server
+Download a file as a stored file, or read structured notebook and directory content
 
 #### Input
 
@@ -75,11 +75,11 @@ Read a file or notebook from a Jupyter server
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `name` | string | File or notebook name |
-| `path` | string | Path relative to the server root |
-| `mimetype` | string | MIME type of the content |
-| `text` | string | Text content, for text files and notebooks \(JSON-stringified\) |
-| `file` | file | Binary content stored as a file, for base64-format content |
+| `file` | file | Downloaded file |
+| `text` | string | JSON-stringified notebook or directory content |
+| `name` | string | Notebook or directory name |
+| `path` | string | Notebook or directory path |
+| `mimetype` | string | Notebook or directory MIME type |
 
 ### Jupyter Create File
 

apps/docs/content/docs/integrations/microsoft_dataverse.mdx

@@ -152,11 +152,7 @@ Download a file from a Dataverse file or image column and return its stored file
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
 | `file` | file | Downloaded file stored in execution files |
-| `fileName` | string | Name of the downloaded file |
-| `fileSize` | number | File size in bytes |
-| `mimeType` | string | MIME type of the file |
 | `fileColumn` | string | File column the file was downloaded from |
-| `success` | boolean | Whether the file was downloaded successfully |
 
 ### Execute Microsoft Dataverse Action
 

apps/docs/content/docs/integrations/quiver.mdx

@@ -57,7 +57,6 @@ Generate SVG images from text prompts using QuiverAI
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `file` | file | First generated SVG stored as a file |
 | `files` | file[] | All generated SVG files |
 | `id` | string | Request ID |
 | `usage` | json | Token usage statistics |
@@ -87,7 +86,6 @@ Convert raster images into vector SVG format using QuiverAI
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `file` | file | First generated SVG stored as a file |
 | `files` | file[] | All generated SVG files |
 | `id` | string | Request ID |
 | `usage` | json | Token usage statistics |

apps/docs/content/docs/integrations/sftp.mdx

@@ -82,11 +82,7 @@ Download a file from a remote SFTP server
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `success` | boolean | Whether the download was successful |
 | `file` | file | Downloaded file stored in execution files |
-| `fileName` | string | Name of the downloaded file |
-| `size` | number | File size in bytes |
-| `message` | string | Operation status message |
 
 ### SFTP List Directory
 

apps/docs/content/docs/integrations/ssh.mdx

@@ -161,12 +161,8 @@ Download a file from a remote SSH server
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `downloaded` | boolean | Whether the file was downloaded successfully |
 | `file` | file | Downloaded file stored in execution files |
-| `fileName` | string | Name of the downloaded file |
 | `remotePath` | string | Source path on the remote server |
-| `size` | number | File size in bytes |
-| `message` | string | Operation status message |
 
 ### SSH List Directory
 

apps/sim/blocks/blocks/binary-download-versioning.test.ts

@@ -84,3 +84,17 @@ describe.each(cases)(
     })
   }
 )
+
+it('keeps Dataverse upload metadata separate from canonical download files', () => {
+  expect(MicrosoftDataverseV2Block.outputs).not.toHaveProperty('fileSize')
+  expect(MicrosoftDataverseV2Block.outputs).not.toHaveProperty('mimeType')
+  expect(MicrosoftDataverseV2Block.outputs.fileName.condition).toEqual({
+    field: 'operation',
+    value: 'upload_file',
+  })
+  expect(MicrosoftDataverseV2Block.outputs.success.condition).toEqual({
+    field: 'operation',
+    value: 'download_file',
+    not: true,
+  })
+})

apps/sim/blocks/blocks/jupyter.test.ts

@@ -0,0 +1,35 @@
+import { describe, expect, it } from 'vitest'
+import { JupyterBlock, JupyterV2Block } from '@/blocks/blocks/jupyter'
+
+describe('Jupyter block versions', () => {
+  it('offers v2 for new blocks and preserves the legacy block', () => {
+    expect(JupyterBlock.hideFromToolbar).toBe(true)
+    expect(JupyterBlock.sunset).toEqual({ status: 'legacy', replacedBy: 'jupyter_v2' })
+    expect(JupyterV2Block.hideFromToolbar).toBe(false)
+    expect(JupyterV2Block.sunset).toBeUndefined()
+    expect(JupyterV2Block.canvasPresentation).toBe(JupyterBlock.canvasPresentation)
+    expect(JupyterV2Block.subBlocks).toBe(JupyterBlock.subBlocks)
+  })
+
+  it.each(JupyterBlock.tools.access)('versions only Get Content: %s', (operation) => {
+    const id = operation === 'jupyter_get_content' ? 'jupyter_get_content_v2' : operation
+    expect(JupyterBlock.tools.config.tool({ operation })).toBe(operation)
+    expect(JupyterV2Block.tools.config?.tool({ operation })).toBe(id)
+    expect(JupyterV2Block.tools.access).toContain(id)
+  })
+
+  it('preserves the path and credentials for the versioned read', () => {
+    expect(
+      JupyterV2Block.tools.config?.params?.({
+        operation: 'jupyter_get_content',
+        serverUrl: 'https://jupyter.example.com',
+        token: 'token',
+        path: 'reports/book.xlsx',
+      })
+    ).toEqual({
+      serverUrl: 'https://jupyter.example.com',
+      token: 'token',
+      path: 'reports/book.xlsx',
+    })
+  })
+})