Repository navigation
restore slackengine to 3008 #70537
Replies: 6 comments
|
There's definitely some inconsistency here - not sure why we'd keep the execution module but not also keep the state module. I'd probably argue that it should all be removed and go into a salt extension - given that the slack api seems to change a fair bit and it hasn't really seen any maintenance recently. @ITJamie - I see you have various issues about slack components, so I assume you use fairly heavily? Does the old (non-bolt) engine work anymore? |
|
It does technically work if you have old api creds but the old slack apis are not getting updated. And new users cant set that up anymore i believe. The bolt one works but has a few fixes im maintaining locally. |
|
If you want to create a PR adding it back I'm okay with it. Long term slack integration is the sort of thing I would prefer be maintained in a salt extension. |
|
Having thought about this more. I feel strongly slack integration should be moved to a salt extension. |
|
This feature request was moved out of the issue tracker as part of a backlog cleanup — there is no active development commitment behind it. If you intend to implement this, please leave a comment and a maintainer can convert the discussion back to an issue to track the PR. |
|
Finishing the purge on master in #70539 (removes salt.modules.slack_notify and salt.utils.slack). A community salt-extension will be the forward path for anyone needing Slack integration; 3008.x stays as-is since the modules already shipped in that LTS. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
it seems strange that some parts of the slack integrations were kept in core in 3008:
salt/salt/utils/slack.py
Line 4 in f4db526
salt/salt/modules/slack_notify.py
Line 4 in f4db526
but the slackengine's were not?
the original slack engine was in since 2016.3.0 and the (optional) replacement using the modern backend (slack_bolt) was added in 3006
All reactions