Merge pull request #189 from quicknode/claude/affectionate-turing-4owvhb

Remove false re-entry claims from checks-effects-interactions comments

Author: mikemaccana

finance/fundraiser/anchor-v1/README.md

@@ -81,7 +81,7 @@ All token accounts use `anchor_spl::token_interface` types (`InterfaceAccount<Mi
 
 ### Onchain math
 
-All balance and counter arithmetic uses `checked_*` operations and returns `FundraiserError::MathOverflow` on overflow. Both handlers that move tokens out of the vault update program state before issuing the transfer CPI (checks-effects-interactions).
+All balance and counter arithmetic uses `checked_*` operations and returns `FundraiserError::MathOverflow` on overflow.
 
 ## Lifecycle
 

finance/fundraiser/anchor-v1/programs/fundraiser/src/instructions/contribute.rs

@@ -91,7 +91,6 @@ pub fn handle_contribute(
         .checked_add(amount)
         .ok_or(FundraiserError::MathOverflow)?;
 
-    // Checks-effects-interactions: update state before the transfer CPI.
     accounts.fundraiser.current_amount = accounts
         .fundraiser
         .current_amount

finance/fundraiser/anchor-v1/programs/fundraiser/src/instructions/refund.rs

@@ -80,7 +80,6 @@ pub fn handle_refund(accounts: &mut RefundAccountConstraints) -> Result<()> {
         FundraiserError::TargetMet
     );
 
-    // Checks-effects-interactions: update state before the transfer CPI.
     let refund_amount = accounts.contribution.amount;
     accounts.fundraiser.current_amount = accounts
         .fundraiser

finance/fundraiser/anchor/README.md

@@ -82,7 +82,7 @@ All token accounts use `anchor_spl::token_interface` types (`InterfaceAccount<Mi
 
 ### Onchain math
 
-All balance and counter arithmetic uses `checked_*` operations and returns `FundraiserError::MathOverflow` on overflow. Both handlers that move tokens out of the vault update program state before issuing the transfer CPI (checks-effects-interactions).
+All balance and counter arithmetic uses `checked_*` operations and returns `FundraiserError::MathOverflow` on overflow.
 
 ## Lifecycle
 

finance/fundraiser/anchor/programs/fundraiser/src/instructions/contribute.rs

@@ -91,7 +91,6 @@ pub fn handle_contribute(
         .checked_add(amount)
         .ok_or(FundraiserError::MathOverflow)?;
 
-    // Checks-effects-interactions: update state before the transfer CPI.
     accounts.fundraiser.current_amount = accounts
         .fundraiser
         .current_amount

finance/fundraiser/anchor/programs/fundraiser/src/instructions/refund.rs

@@ -80,7 +80,6 @@ pub fn handle_refund(accounts: &mut RefundAccountConstraints) -> Result<()> {
         FundraiserError::TargetMet
     );
 
-    // Checks-effects-interactions: update state before the transfer CPI.
     let refund_amount = accounts.contribution.amount;
     accounts.fundraiser.current_amount = accounts
         .fundraiser

finance/fundraiser/quasar/src/instructions/check_contributions.rs

@@ -59,7 +59,6 @@ pub fn handle_check_contributions(
         FundraiserError::TargetNotMet
     );
 
-    // Update state before the transfer CPI (checks-effects-interactions).
     accounts.fundraiser.claimed = PodBool::from(true);
 
     // Fundraiser PDA signer seeds: ["fundraiser", maker, bump].

finance/fundraiser/quasar/src/instructions/contribute.rs

@@ -69,7 +69,6 @@ pub fn handle_contribute(
     )?;
     require!(now < deadline, FundraiserError::FundraiserEnded);
 
-    // Update state before the transfer CPI (checks-effects-interactions).
     let current_amount: u64 = accounts.fundraiser.current_amount.into();
     accounts.fundraiser.current_amount = PodU64::from(
         current_amount

finance/fundraiser/quasar/src/instructions/refund.rs

@@ -74,7 +74,6 @@ pub fn handle_refund(
 
     let refund_amount: u64 = accounts.contribution.amount.into();
 
-    // Update state before the transfer CPI (checks-effects-interactions).
     accounts.fundraiser.current_amount = PodU64::from(
         current_amount
             .checked_sub(refund_amount)

finance/managed-fund/anchor-v1/programs/managed-fund/src/instructions/collect_fees.rs

@@ -80,7 +80,7 @@ pub fn handle_collect_fees(context: Context<CollectFeesAccountConstraints>) -> R
         return Ok(());
     }
 
-    // Checks-effects-interactions: update total_shares before CPI
+    // Add the fee shares to the recorded supply
     context.accounts.fund.total_shares = total_shares
         .checked_add(fee_shares)
         .ok_or(FundError::MathOverflow)?;