From 7f024065781aea56bcff0d49d74f42e4d2f5ea42 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Wed, 18 Nov 2026 09:52:56 +0100 Subject: [PATCH] Test skipRemove once at the end of unmount() Both trailing statements were guarded by !skipRemove. --- src/diff/index.js | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/diff/index.js b/src/diff/index.js index 8f3e51effd..c3e499ac7e 100644 --- a/src/diff/index.js +++ b/src/diff/index.js @@ -799,18 +799,19 @@ export function unmount(vnode, parentVNode, skipRemove) { // A component that suspended while hydrating owns its range's markers, // and its content too while still pending. - if ( - !skipRemove && - (r = vnode._component) && - (r = r._excess) && - (end = rangeEnd(r, (nodes = []))) - ) { - if (r == vnode._dom) nodes.some(removeNode); - removeNode(end); - removeNode(r); - } + if (!skipRemove) { + if ( + (r = vnode._component) && + (r = r._excess) && + (end = rangeEnd(r, (nodes = []))) + ) { + if (r == vnode._dom) nodes.some(removeNode); + removeNode(end); + removeNode(r); + } - if (!skipRemove) removeNode(vnode._dom); + removeNode(vnode._dom); + } vnode._dom = vnode._component = vnode._parent = NULL; }