Repository navigation
Respect pip configuration when bootstrapping Cookiecutter - #8669
Merged
Stella Huang (StellaHuang95) merged 1 commit intoNov 12, 2026
Conversation
Run ensurepip in a child CPython process so its pip environment cleanup does not affect the subsequent package upgrade. Preserve IronPython behavior and add a regression test for configured pip settings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7ba6e19-b52e-4441-9c57-830ac221172c
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Stella Huang (StellaHuang95)
enabled auto-merge (squash)
November 12, 2026 20:57
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
approved these changes
Nov 12, 2026
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensurepipin a child process so itsPIP_*cleanup cannot disable configuration for the following pip upgradeUser impact
Cookiecutter setup now honors the user's normal pip configuration, including private or corporate package feeds, instead of unexpectedly contacting public PyPI after
ensurepipruns.Validation
VSInterpretersTestsfor Dev18EnsurePipPreservesPipConfiguration: passedVSInterpretersTestsselection: 9/9 passed--without-pipenvironment: bootstrap used the configured feed, made nofiles.pythonhosted.orgrequests, installed Cookiecutter 2.7.1 andfuture, and passedcookiecutter_check.pybrettcannon/python-azure-web-app-cookiecutterThe existing environment-dependent
DetectReqPkgMissingPython3Asynctest failed once during the full assembly run and hung when isolated; its legacy package setup passes independently and it does not exercise this change.Fixes #8605