fix(hidi): place Pester test inside its test project (#896)

Relocate the unchanged NuGet helper Pester suite into the physical Hidi test project so SonarScanner assigns it to module test inputs. Remove the ineffective virtual link and update the workflow and documented invocation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d8b2d595-33d1-4ed7-a6fa-047f6ca57a36

Author: gavinbarron

.github/workflows/sonarcloud.yml

@@ -70,7 +70,7 @@ jobs:
           $outputRoot = Join-Path $PWD 'artifacts\hidi\powershell-coverage'
           New-Item -ItemType Directory -Force -Path $outputRoot | Out-Null
           $configuration = New-PesterConfiguration
-          $configuration.Run.Path = 'test\scripts\check-nuget-package-published.Tests.ps1'
+          $configuration.Run.Path = 'test\Microsoft.OpenApi.Hidi.Tests\check-nuget-package-published.Tests.ps1'
           $configuration.Run.PassThru = $true
           $configuration.CodeCoverage.Enabled = $true
           $configuration.CodeCoverage.Path = $helper

src/Microsoft.OpenApi.Hidi/readme.md

@@ -89,8 +89,10 @@ access, the ESRP connection and protected `nuget-org` environment authorization
 before cutover; local packaging does not prove production signing or publishing.
 
 The private-feed helper has isolated Pester 5.7.1 tests (no live feed access).
-Run `Invoke-Pester .\test\scripts\check-nuget-package-published.Tests.ps1` to
-execute the cases. The Sonar workflow also measures helper line coverage and
+Run `Invoke-Pester .\test\Microsoft.OpenApi.Hidi.Tests\check-nuget-package-published.Tests.ps1` to
+execute the cases. The test resides physically inside the Hidi test project so
+SonarScanner for .NET classifies it as test code, rather than root source code.
+The Sonar workflow also measures helper line coverage and
 imports a generic coverage report alongside the existing C# OpenCover reports.
 
 ### Windows executable

test/Microsoft.OpenApi.Hidi.Tests/Microsoft.OpenApi.Hidi.Tests.csproj

@@ -29,7 +29,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Include="..\scripts\check-nuget-package-published.Tests.ps1" Link="Scripts\check-nuget-package-published.Tests.ps1" />
     <None Update="testconfig.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>