fix(tests): place v2 Pester tests inside the Hidi test project (#895)

* fix(tests): classify v2 NuGet helper Pester tests

Link the existing Pester script into the Hidi test project so analysis treats it as test code without excluding files or changing release behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f8d164a5-72a6-482a-8749-ae5c6e47a0e5

* fix(tests): place v2 Pester tests inside the Hidi test project

Move the existing script unchanged into the physical test project directory so the scanner assigns it to test sources. Remove the ineffective sibling link and update the workflow and local test documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f8d164a5-72a6-482a-8749-ae5c6e47a0e5

---------

Copilot-Session: f8d164a5-72a6-482a-8749-ae5c6e47a0e5

Author: gavinbarron

.github/workflows/sonarcloud.yml

@@ -70,7 +70,7 @@ jobs:
           $outputRoot = Join-Path $PWD 'artifacts\hidi\powershell-coverage'
           New-Item -ItemType Directory -Force -Path $outputRoot | Out-Null
           $configuration = New-PesterConfiguration
-          $configuration.Run.Path = 'test\scripts\check-nuget-package-published.Tests.ps1'
+          $configuration.Run.Path = 'test\Microsoft.OpenApi.Hidi.Tests\check-nuget-package-published.Tests.ps1'
           $configuration.Run.PassThru = $true
           $configuration.CodeCoverage.Enabled = $true
           $configuration.CodeCoverage.Path = $helper

README.md

@@ -114,8 +114,10 @@ This pipeline implementation does not enable publishing or authorize resources.
 
 The SonarCloud workflow runs the private-feed helper tests with Pester 5.7.1 and
 converts measured JaCoCo line hits to Sonar generic coverage, alongside the
-existing C# OpenCover reports. Run the helper tests locally with
-`Import-Module Pester -RequiredVersion 5.7.1; Invoke-Pester .\test\scripts\check-nuget-package-published.Tests.ps1`.
+existing C# OpenCover reports. The Pester script resides inside the Hidi test
+project directory so Sonar assigns it to test sources; a linked sibling file
+does not establish that ownership. Run the helper tests locally with
+`Import-Module Pester -RequiredVersion 5.7.1; Invoke-Pester .\test\Microsoft.OpenApi.Hidi.Tests\check-nuget-package-published.Tests.ps1`.
 
 ---