Skip to content

Cross-compile to Scala 2.13 - #31

Merged
lolgab merged 1 commit into
masterfrom
cross-compile-scala-2.13
Aug 10, 2026
Merged

Cross-compile to Scala 2.13#31
lolgab merged 1 commit into
masterfrom
cross-compile-scala-2.13

Conversation

@lolgab

@lolgab lolgab commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Scala 2.13.16 to crossScalaVersions alongside 2.12.20, so sbt +compile/+publish build both.
  • apollo-runtime dep is a plain Java artifact (%, not %%), so no cross-version lookup issue.

Test plan

  • sbt +compile succeeds for both 2.12.20 and 2.13.16 locally.
  • CI already runs sbt +compile / sbt +publish (cross build), no workflow changes needed.

Add 2.13.16 to crossScalaVersions so sbt +compile/+publish build both versions.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR successfully introduces support for Scala 2.13.16 alongside the existing 2.12.20 version. Automated analysis from Codacy shows that the project remains up to standards with no new quality issues or complexity increases introduced by these configuration changes.

The primary focus for this PR should be verifying that the cross-compilation actually succeeds in the CI environment. While the build.sbt changes enable the functionality, confirmation of successful artifact generation for both versions is required to satisfy the acceptance criteria.

Test suggestions

  • Successful compilation under Scala 2.12.20
  • Successful compilation under Scala 2.13.16
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Successful compilation under Scala 2.12.20
2. Successful compilation under Scala 2.13.16

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@lolgab
lolgab enabled auto-merge August 10, 2026 12:12
@lolgab
lolgab merged commit 1df314b into master Aug 10, 2026
3 checks passed
@lolgab
lolgab deleted the cross-compile-scala-2.13 branch August 10, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants