Cross-compile to Scala 2.13 - #31
Conversation
Add 2.13.16 to crossScalaVersions so sbt +compile/+publish build both versions.
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR successfully introduces support for Scala 2.13.16 alongside the existing 2.12.20 version. Automated analysis from Codacy shows that the project remains up to standards with no new quality issues or complexity increases introduced by these configuration changes.
The primary focus for this PR should be verifying that the cross-compilation actually succeeds in the CI environment. While the build.sbt changes enable the functionality, confirmation of successful artifact generation for both versions is required to satisfy the acceptance criteria.
Test suggestions
- Successful compilation under Scala 2.12.20
- Successful compilation under Scala 2.13.16
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Successful compilation under Scala 2.12.20
2. Successful compilation under Scala 2.13.16
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Summary
crossScalaVersionsalongside 2.12.20, sosbt +compile/+publishbuild both.apollo-runtimedep is a plain Java artifact (%, not%%), so no cross-version lookup issue.Test plan
sbt +compilesucceeds for both 2.12.20 and 2.13.16 locally.sbt +compile/sbt +publish(cross build), no workflow changes needed.