fix(nextjs): key App Router ClerkProvider children - #9615
fix(nextjs): key App Router ClerkProvider children#9615therealtunguyen wants to merge 2 commits into
Conversation
|
@therealtunguyen is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 66eaa56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe App Router client Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized fix adds stable keys to App Router ClerkProvider children to prevent a development-only React warning; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes address issue
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Description
Fixes #9415.
Adds stable keys to the static App Router
ClerkProviderchildren so React does not emit a development-only unique-key warning when RSC streams them as lazy references. The issue's root-cause analysis describes the streaming behavior behind the warning.Reproduction: https://github.com/ant1m4tt3r/clerk-dynamic-key-warning — the warning is logged on every page load before this change and gone after it.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change