Repository navigation
How should external contributors submit pull requests now that PR creation is limited to collaborators? #934
Unanswered
BourezBastien
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
CONTRIBUTING.md walks external contributors through the standard workflow — fork, branch, then open a pull request (and the PR template assumes the same). However, when opening a PR as a non-collaborator, GitHub now rejects it with:
Concretely: I have a fix ready for #854 (
NextDrupalBase.addLocalePrefix()— the locale is now only treated as already present when it is a complete path segment, so paths like/enable/testingwith localeenget the/enprefix). It lives on my forkBourezBastien/next-drupal, branchfix/854-add-locale-prefix(commit 30b00eb, rebased on current main, 7 test cases added,next-drupal-base.tsstays at 100% coverage under the mocked suite). Details are in the issue comment: #854 (comment)Questions:
In the meantime I'm glad to help with issue triage and documentation.
@robdecker — apologies for the direct ping; you seem to be the most active maintainer lately. Feel free to redirect me if someone else should handle this.
All reactions