diff --git a/internal/engine/limits_test.go b/internal/engine/limits_test.go index add322da9..8fac487d0 100644 --- a/internal/engine/limits_test.go +++ b/internal/engine/limits_test.go @@ -125,3 +125,27 @@ func TestStringify_Formats(t *testing.T) { assert.Equal(t, `{"a":[1,{"b":null}],"c":{},"d":[],"e":"s"}`, stringifyCompact(value, vm, nil)) assert.Equal(t, "{\n \"a\": [\n 1,\n {\n \"b\": null\n }\n ],\n \"c\": {},\n \"d\": [],\n \"e\": \"s\"\n}", Stringify(value, vm, 0)) } + +func TestStringify_ArrayIndexes(t *testing.T) { + for _, tc := range []struct { + name, expression string + }{ + {"holes", `[1, , 3, ,]`}, + {"only holes", `new Array(3)`}, + {"extra property", `Object.assign([1, 2], {note: "metadata"})`}, + {"hidden index", `Object.defineProperty([1, 2], "0", {enumerable: false})`}, + {"deleted element", `(() => { const a = [1, 2, 3]; delete a[1]; return a })()`}, + } { + t.Run(tc.name, func(t *testing.T) { + vm := goja.New() + value, err := vm.RunString("var value = " + tc.expression + "; value") + require.NoError(t, err) + compact, err := vm.RunString("JSON.stringify(value)") + require.NoError(t, err) + indented, err := vm.RunString("JSON.stringify(value, null, 2)") + require.NoError(t, err) + assert.Equal(t, compact.String(), stringifyCompact(value, vm, nil)) + assert.Equal(t, indented.String(), Stringify(value, vm, 0)) + }) + } +} diff --git a/internal/engine/stringify.go b/internal/engine/stringify.go index 0eafa592d..ad58f06c7 100644 --- a/internal/engine/stringify.go +++ b/internal/engine/stringify.go @@ -4,6 +4,7 @@ import ( "fmt" "math/big" "reflect" + "strconv" "strings" "time" @@ -141,19 +142,23 @@ func (s *stringifier) write(value goja.Value, depth int) { case reflect.Slice: arr := value.ToObject(vm) - keys := arr.Keys() - if len(keys) == 0 { + length := arr.Get("length").ToInteger() + if length == 0 { s.out.WriteString("[]") return } s.enter(arr) s.out.WriteByte('[') - for i, key := range keys { + for i := int64(0); i < length; i++ { if i > 0 { s.out.WriteByte(',') } s.newline(depth + 1) - s.write(arr.Get(key), depth+1) + item := arr.Get(strconv.FormatInt(i, 10)) + if item == nil { + item = goja.Undefined() + } + s.write(item, depth+1) } s.newline(depth) s.out.WriteByte(']')