Repository navigation
Commit f1a9740
committed
fix(ui): anchor container chrome to the container, not a descendant
`BlockPopover` searched for any `[data-node-type]` under the node view's
DOM, which matches a nested child container's root when the author's own
root isn't stamped - anchoring the popover to a child. The search is now
scoped to the block's own type, and falls back to the container's node
element rather than descending into its contentDOM (the first child's box).
`SideMenu` read `container.firstElementChild!` for the handle's x
position, which is null for a container rendering no element children.1 parent e479c17 commit f1a9740
2 files changed
Lines changed: 12 additions & 6 deletions
File tree
- packages
- core/src/extensions/SideMenu
- react/src/components/Popovers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
307 | | - | |
| 307 | + | |
| 308 | + | |
308 | 309 | | |
309 | 310 | | |
310 | 311 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
46 | 50 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
| |||
0 commit comments