CSTACKEX-306: setting the exception msg more align to the situation

Author: rajiv-jain-netapp

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

@@ -1007,16 +1007,19 @@ private TemplateInfo createManagedTemplateVolume(TemplateInfo srcTemplateInfo, P
                 } else {
                     errMesg = callback.result.getResult();
                 }
-                templateOnPrimary.processEvent(Event.OperationFailed);
                 throw new CloudRuntimeException(String.format("Unable to create template %s on primary storage %s: %s", templateOnPrimary.getImage(), destPrimaryDataStore, errMesg));
             }
 
             templateOnPrimary.processEvent(Event.OperationSucceeded);
 
         } catch (Throwable e) {
             logger.debug("Failed to create template volume on storage", e);
-            templateOnPrimary.processEvent(Event.OperationFailed);
-            throw new CloudRuntimeException(e.getMessage());
+            try {
+                templateOnPrimary.processEvent(Event.OperationFailed);
+            } catch (Exception stateEx) {
+                logger.warn("Unable to mark template {} as failed on primary storage {}: {}", templateOnPrimary.getImage(), destPrimaryDataStore, stateEx.getMessage());
+            }
+            throw new CloudRuntimeException(e.getMessage(), e);
         } finally {
             _tmpltPoolDao.releaseFromLockTable(templatePoolRefId);
         }

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java

@@ -111,7 +111,9 @@ public CloudStackVolume createTemplateCache(StoragePoolVO storagePool, TemplateI
                                                 Map<String, String> details, long sizeInBytes) {
         if (sizeInBytes <= 0) {
             throw new CloudRuntimeException("Unknown virtual size for template [" + templateInfo.getId()
-                    + "]; cannot size the template LUN on pool [" + storagePool.getId() + "]");
+                    + "]; cannot size the template LUN on pool [" + storagePool.getId() + "]. The template size in vm_template"
+                    + " is unset; verify the template was registered/seeded with its virtual size (virtualsize in"
+                    + " template.properties on secondary storage).");
         }
 
         CloudStackVolume request = buildTemplateLunRequest(storagePool, details, templateInfo.getId(), sizeInBytes);